Refactor Dimension Handling and Optimize Type Definitions #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the dimension handling functions in the react-native-responsive-screen library to improve performance, readability, and type safety.
Overview: Optimized the widthPercentageToDP and heightPercentageToDP functions for better efficiency.
Consolidated the handling of orientation changes to prevent memory leaks.
Changes Made: Destructured screen dimensions for clarity.
Simplified the logic for parsing percentage inputs in the dimension calculation functions.
Enhanced TypeScript definitions for the listenOrientationChange function, specifying a more accurate type for the screenClassComponent parameter.
Reasoning: These changes aim to enhance code maintainability and usability for developers using the library. Improved type definitions help reduce potential type-related issues.
Testing:Verified that the dimension calculations work correctly in a sample React Native application across different screen sizes.
Additional Notes: Please review the changes and let me know if there are any concerns or suggestions for further improvements. I'm open to making adjustments as needed.